-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using postal codes for better match #159
Comments
Placeholder uses bounding-boxes in order to determine if tokens overlap spatially. We could buffer the points to generate expanded bounding boxes, then it would be a matter of ensuring that the quality is good. It would be possible to do but would require some time to build and test, if you'd like to pursue the issue further I'd be happy to assist. |
Can you please provide some examples that can be used as acceptance tests for this feature? |
Here are some cases that didn't quite work, but can be improved greatly with postal code lookups. Some of these are misspells, some are insufficient. State name expansion is another thing that can help here - but if we take care of postal codes, state names are covered too.
|
I'm working on adding postal code support. Feedback welcome... Here's what I'm doing: Objective: Expand postal code to admin1/2/3 names (state / county / region / locality..) and use expanded form for Placeholder search
Notes
|
Some updates:
Overall: I'm happy to share the code. But am not sure if it will be useful, since it does deviate from the core Placeholder promise of parsing a single line plus it uses some external data. If enough people are interested, I can make this into a PR. |
For anyone who's interested, all my changes are here: |
Is there a reason why placeholder does not use postal codes for lookups? In some ad-hoc tests I did, Placeholder could not find correct places due to insufficient address / misspellings etc.
I tried looking up the postal code (which was available) in Geonames post code data, found a match, then used location names from Geonames post code data in Placeholder, and then Placeholder could correctly identify the place.
I don't have much experience with this, so don't know all the intricacies. I have read that post codes can be a mess. But if an address has a country and postcode, we can pretty much find the exact location just with that information - at least that's why I am thinking..
What are the problems with using post codes then?
The text was updated successfully, but these errors were encountered: