Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX on sign-in modal. #351

Open
gianfra-t opened this issue Jan 3, 2025 · 6 comments · May be fixed by #350
Open

Improve UX on sign-in modal. #351

gianfra-t opened this issue Jan 3, 2025 · 6 comments · May be fixed by #350
Assignees

Comments

@gianfra-t
Copy link
Contributor

gianfra-t commented Jan 3, 2025

Currently, we do not provide any kind of feedback when the user clicks on the Sign-In button when off-ramping ARS.
This may not have been an issue with extension wallets since after clicking, the wallet would pop-up and essentially work as a continuation of the UI.

Nevertheless, for wallet connect or any other set-up where the user must go manually to the wallet, we need to provide some sort of feedback such that after clicking, it is clear that one must go to the wallet to sign.

@gianfra-t
Copy link
Contributor Author

@pendulum-chain/product This is quite an important change, yet relatively simple, for users who offramp ARS and use wallet-connect, for instance.

@gianfra-t gianfra-t linked a pull request Jan 3, 2025 that will close this issue
@prayagd
Copy link
Collaborator

prayagd commented Jan 8, 2025

Hey team! Please add your planning poker estimate with Zenhub @ebma @gianfra-t @Sharqiewicz

@gianfra-t gianfra-t self-assigned this Jan 13, 2025
@gianfra-t gianfra-t linked a pull request Jan 13, 2025 that will close this issue
@prayagd
Copy link
Collaborator

prayagd commented Jan 16, 2025

@pendulum-chain/devs updated the description to include the reset of the APP if network switch before continue with Partner

@prayagd
Copy link
Collaborator

prayagd commented Jan 16, 2025

@pendulum-chain/devs sorry for the confusion but #348 would eliminate this scenario of the network switch as the pop-up with continue partner would make the behind screen disbaled

@ebma
Copy link
Member

ebma commented Jan 16, 2025

True, thanks for pointing it out. So I understand we don't need to worry about the bug with the network selector anymore as the bug can't happen going forward @prayagd?

@prayagd
Copy link
Collaborator

prayagd commented Jan 16, 2025

yes you are right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants