Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests dependency on numpy? #79

Open
vreuter opened this issue May 28, 2023 · 1 comment
Open

Missing tests dependency on numpy? #79

vreuter opened this issue May 28, 2023 · 1 comment
Assignees
@vreuter
Labels
bug Something isn't working question Further information is requested

Comments

@vreuter
Copy link
Member

vreuter commented May 28, 2023

https://github.com/pepkit/attmap/blob/dev/tests/test_AttMap.py#L7

It looks like at least one test module is using numpy without having declared it as a dependency in requirements/requirements-test.txt
@vreuter vreuter added bug Something isn't working question Further information is requested labels May 28, 2023
@vreuter vreuter self-assigned this May 28, 2023
vreuter added a commit to vreuter/attmap that referenced this issue May 28, 2023
@vreuter
add numpy dependency for tests; close pepkit#79
8080932
@nsheff
Copy link
Contributor

nsheff commented Sep 14, 2023

yeah I guess that makes sense... thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vreuter vreuter

Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsheff @vreuter