Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on submit validate when destination is graph depot #15

Open
groboclown opened this issue Jul 22, 2022 · 1 comment
Open

Failure on submit validate when destination is graph depot #15

groboclown opened this issue Jul 22, 2022 · 1 comment

Comments

@groboclown
Copy link

groboclown commented Jul 22, 2022

A key error can happen if a change has no revisions:

Traceback (most recent call last):
  File "/home/user/p4transfer/P4Transfer.py", line 2579, in replicate
    num_changes = self.replicate_changes()
  File "/home/user/p4transfer/P4Transfer.py", line 2396, in replicate_changes
    targetChange = self.target.replicateChange(fileRevs, specialMoveRevs, srcFileLogs, change, self.source.p4.port)
  File "/home/user/p4transfer/P4Transfer.py", line 1574, in replicateChange
    self.validateSubmittedChange(newChangeId, fileRevs)
  File "/home/user/p4transfer/P4Transfer.py", line 1624, in validateSubmittedChange
    for (n, rev) in enumerate(change['rev']):
KeyError: 'rev'

I added a bit of debugging around this for the corresponding change object (returned from self.p4cmd('describe', '-s', newChangeId)[0]). The dictionary looks like:

{
    'change': '1234',
    'user': 'someuser',
    'client': 'migration-target',
    'time': '1594805092',
    'desc': '(the changelist description)',
    'status': 'submitted',
    'changeType': 'public',
    'path': ''
}

The destination depot is a graph depot, which makes the change description different.

@groboclown groboclown changed the title Failure when a change has no revisions Failure on submit validate when destination is graph depot Jul 22, 2022
@groboclown
Copy link
Author

There seem to be many issues if the target depot is a graph depot. I'm enumerating those now and will put together a comprehensive set of updates for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant