From c0a0f5de50bceb62cc48979913493419cf7e06a2 Mon Sep 17 00:00:00 2001 From: filmaj Date: Tue, 6 Dec 2016 11:26:23 -0800 Subject: [PATCH 1/4] First stab at basic contribution guideline as well as a pull-request-based app submission guidelines --- CONTRIBUTING.md | 9 +++++++++ PULL_REQUEST_TEMPLATE.md | 16 ++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 CONTRIBUTING.md create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..a8f1c3515 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,9 @@ +# Contribution Guidelines + +## Submitting an Application to the Showcase + +Please submit a pull request to the [app repository](https://github.com/phonegap/app) and fill out the Pull Request template! + +## Filing Issues with the Site + +Go ahead and file an issue, providing as many reproduction details as possible! diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..0f2005d8b --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,16 @@ +# Application Submission to the Showcase + +If you want to submit your application to be displayed on the PhoneGap App +Showcase, then follow this submission template to help expedite the review of +your app. + +The following is a non-exhaustive list of things that the PhoneGap review team +looks for in showcase applications: + +- [ ] Is the app cross-platform? +- [ ] Does it have a pretty good visual design? +- [ ] Is your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? +- [ ] Does it have at least a 4/5 star rating on the stores? +- [ ] Is it an app with a relatively unique concept? +- [ ] Is the app useful or impactful? +- [ ] Does it contain some level of complexity, showing off what is possible with PhoneGap? From b6da7a1c9acd754c4999133850dcb1b6ab42be10 Mon Sep 17 00:00:00 2001 From: Joni Rustulka Date: Tue, 6 Dec 2016 11:51:40 -0800 Subject: [PATCH 2/4] Update PULL_REQUEST_TEMPLATE.md Revising wording for consistency with website, and for tone --- PULL_REQUEST_TEMPLATE.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 0f2005d8b..17f2542c8 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,16 +1,15 @@ # Application Submission to the Showcase -If you want to submit your application to be displayed on the PhoneGap App -Showcase, then follow this submission template to help expedite the review of +If you'd like to share your application on the PhoneGap App +Showcase, please follow this submission template to help expedite the review of your app. -The following is a non-exhaustive list of things that the PhoneGap review team -looks for in showcase applications: +Further, the following is a non-exhaustive list of criteria that the PhoneGap review team +looks for in Showcase applications: -- [ ] Is the app cross-platform? -- [ ] Does it have a pretty good visual design? -- [ ] Is your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? -- [ ] Does it have at least a 4/5 star rating on the stores? +- [ ] Is it an example of great design? +- [ ] Is the app cross-platform -- meaning, s your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? +- [ ] Does it have at great star rating in the app store(s)? - [ ] Is it an app with a relatively unique concept? - [ ] Is the app useful or impactful? - [ ] Does it contain some level of complexity, showing off what is possible with PhoneGap? From 9ed243eb31f525de18a5eb2b62ca737a82dc6569 Mon Sep 17 00:00:00 2001 From: filmaj Date: Tue, 6 Dec 2016 13:42:03 -0800 Subject: [PATCH 3/4] some typo fixes plus hard requirements section about app details. --- PULL_REQUEST_TEMPLATE.md | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 17f2542c8..df09a7683 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,28 @@ # Application Submission to the Showcase -If you'd like to share your application on the PhoneGap App -Showcase, please follow this submission template to help expedite the review of -your app. +If you'd like to share your application on the PhoneGap App Showcase, please +follow this submission template to help expedite the review of your app. -Further, the following is a non-exhaustive list of criteria that the PhoneGap review team -looks for in Showcase applications: +## Requirements + +We need to know the basics about your app. In particular: + +- [ ] App name +- [ ] App creator name +- [ ] App creator website +- [ ] App description (no more than a few paragraphs) +- [ ] App icon, 200x200 HiDPI +- [ ] App store links +- [ ] A few app screenshots, you can reuse the ones you submitted to the app store(s) + +## Review Criteria + +Further, the following is a non-exhaustive list of criteria that the PhoneGap +review team looks for in Showcase applications: - [ ] Is it an example of great design? -- [ ] Is the app cross-platform -- meaning, s your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? -- [ ] Does it have at great star rating in the app store(s)? +- [ ] Is the app cross-platform -- meaning, is your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? +- [ ] Does it have a great star rating in the app store(s)? - [ ] Is it an app with a relatively unique concept? - [ ] Is the app useful or impactful? - [ ] Does it contain some level of complexity, showing off what is possible with PhoneGap? From 906b6692f2ce805e4b68b77f90adda6ab9109bda Mon Sep 17 00:00:00 2001 From: Joni Rustulka Date: Tue, 6 Dec 2016 15:08:22 -0800 Subject: [PATCH 4/4] Update PULL_REQUEST_TEMPLATE.md revised some wording --- PULL_REQUEST_TEMPLATE.md | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index df09a7683..14b2d7f86 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -# Application Submission to the Showcase +# Submissions to the App Showcase If you'd like to share your application on the PhoneGap App Showcase, please follow this submission template to help expedite the review of your app. @@ -8,21 +8,23 @@ follow this submission template to help expedite the review of your app. We need to know the basics about your app. In particular: - [ ] App name -- [ ] App creator name -- [ ] App creator website +- [ ] Your name or company name +- [ ] Your email address (we may need to contact you about your submission) +- [ ] Web address (for the app or for the app developer) - [ ] App description (no more than a few paragraphs) -- [ ] App icon, 200x200 HiDPI -- [ ] App store links -- [ ] A few app screenshots, you can reuse the ones you submitted to the app store(s) +- [ ] App icon, 200px X 200px HiDPI +- [ ] App store link(s) +- [ ] At least two app screenshots (but no more than 3). You can reuse the ones you submitted to the app store(s) +- [ ] Optionally, the URL to a video (YouTube, Vimeo for example) ## Review Criteria Further, the following is a non-exhaustive list of criteria that the PhoneGap review team looks for in Showcase applications: -- [ ] Is it an example of great design? -- [ ] Is the app cross-platform -- meaning, is your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? -- [ ] Does it have a great star rating in the app store(s)? -- [ ] Is it an app with a relatively unique concept? -- [ ] Is the app useful or impactful? -- [ ] Does it contain some level of complexity, showing off what is possible with PhoneGap? +- Is it an example of great design? +- Is the app cross-platform -- meaning, is your app available on at least two of the Apple App Store, Google Play Store, or the Windows Store? +- Does it have a great star rating in the app store(s)? +- Is it an app with a relatively unique concept? +- Is the app useful or impactful? +- Does it contain some level of complexity, showing off what is possible with PhoneGap?