Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in Ruby 2.2.0 and later #3

Open
brandt opened this issue Feb 26, 2015 · 9 comments
Open

TypeError in Ruby 2.2.0 and later #3

brandt opened this issue Feb 26, 2015 · 9 comments

Comments

@brandt
Copy link

brandt commented Feb 26, 2015

As of Ruby 2.2.0, digest-sha3 v1.0.2 now produces a TypeError. The problem also occurs in the current 2.3.0-dev build.

The problem doesn't occur in earlier versions of Ruby (verified: 1.9.3-p448, 2.0.0-p451, 2.1.2, 2.1.5).

Example:

2.2.0> require 'digest/sha3'
 => true
2.2.0> Digest::SHA3.digest("foo")
TypeError: wrong argument type Digest::SHA3 (expected digest)
    from (irb):2:in `reset'
    from (irb):2:in `digest'
    from (irb):2:in `digest'
    from (irb):2
    from /Users/bbuckley/.cache/rbenv/versions/2.2.0/bin/irb:11:in `<main>'
@tmornini
Copy link

tmornini commented Mar 3, 2015

👍

2 similar comments
@nesrual
Copy link

nesrual commented Mar 30, 2015

+1

@mikepollitt
Copy link

+1

@FooBarWidget
Copy link
Member

I am no longer maintaining this gem. If someone would like to take over maintenance, please let me know.

@bramski
Copy link
Contributor

bramski commented May 20, 2015

Trying to take up this torch here as we've been using this gem and moving to sha2 digests requires a massive change across a lot of affected systems. Anybody good with C extensions? I'm a bit baffled by the particular error as it seems to be coming from Digest itself and not this library.

@bramski
Copy link
Contributor

bramski commented May 21, 2015

#4 will fix this issue. New version of the gem requires 2.2.x.

@FooBarWidget if you can make me contributor. I can take some maintenance from here. Preferably we could make a PR and get this into ruby 2.3.0. I can ask Nobu if he'd like an implementation of sha3 in future versions of ruby.

@bramski
Copy link
Contributor

bramski commented Jun 23, 2015

Poke

@bramski
Copy link
Contributor

bramski commented Jul 28, 2015

My PR was merged. You can close this issue @brandt .

@tmornini
Copy link

Hurray! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants