From 3eff61332a7214e5e1d61e2fc01e367acae2f91f Mon Sep 17 00:00:00 2001 From: Hongli Lai Date: Sun, 13 Oct 2024 11:03:59 +0200 Subject: [PATCH] C++ tests CI: prevent macOS CI timeout from hiding the logs --- .github/workflows/main.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 686c3619e7..ba255288cd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -103,6 +103,9 @@ jobs: ARCH_AND_OS: aarch64-apple-darwin SCCACHE_AZURE_CONNECTION_STRING: ${{ secrets.AZURE_CI_STORAGE_CONNECTION_STRING }} + - name: Setup dependencies + run: brew install coreutils + - name: Setup misc run: | sudo chmod 755 "$HOME" @@ -115,17 +118,20 @@ jobs: # The AbortHandler doesn't work so well on Github's macOS runners: # - crash-watch invocation freezes the runner, so we disable this. # - resuming the parent process after SIGSTOP doesn't work, so we force kill the parent. + # - force killing the parent may not work, so we enforce a low timeout to prevent + # the test from haging for a long time. We enforce this primarily using the 'timeout' + # command from coreutils instead of Github Actions' timeout, because the latter + # could put the entire job in the "skipped" state and refuse to show logs. + timeout-minutes: 11 run: > sudo env PATH="$PATH" GEM_PATH="$GEM_PATH" PASSENGER_DUMP_WITH_CRASH_WATCH=false PASSENGER_FORCE_TERMINATE_ON_ABORT=true + gtimeout --signal KILL --verbose 600 ../buildout/test/cxx/main working-directory: test - # The AbortHandler may not be able to forcefully kill the parent. We set a low timeout - # to prevent the test from hanging for a long time. - timeout-minutes: 10 - name: Archive logs uses: actions/upload-artifact@v4