Add timer_time field to record
#32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `records` fields have an `elapsed_time` field that tells us how many seconds have passed since the start of the activity. This change adds a `timer_time` field to `records`. It's different from `elapsed_time` because `elapsed_time` tells us the total time that has passed since the activity started, including pauses/rests. `timer_time` that tells us the time shown on the device when the record happened. closes #29
nholden
commented
Mar 24, 2019
| - `true`: Includes a `elapsed_time` field inside each `record` field, containing the elapsed time in seconds since the first record (**default**) | ||
| - `false` | ||
| - `true`: Includes `elapsed_time`, containing the elapsed time in seconds since the first record, and `timer_time`, containing the time shown on the device, inside each `record` field | ||
| - `false` (**default**) |
There was a problem hiding this comment.
It looks like false is the default.
|
@nholden I have "merged" this to the repo https://github.com/jimmykane/fit-parser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
recordsfields have anelapsed_timefield that tells us how many seconds have passed since the start of the activity.This change adds a
timer_timefield torecords. It's different fromelapsed_timebecauseelapsed_timetells us the total time that has passed since the activity started, including pauses/rests.timer_timethat tells us the time shown on the device when the record happened.Example
recordpayloadsBefore this change
{ "timestamp": "2019-03-09T18:36:11.000Z", "elapsed_time": 4569, "position_lat": 32.75025587528944, "position_long": -117.13018745183945, "distance": 14.16679, "altitude": 0.11679999999999996, "speed": 8.686285714285715, "heart_rate": 150, "cadence": 81, "temperature": 15, "fractional_cadence": 0 }After this change
{ "timestamp": "2019-03-09T18:36:11.000Z", "elapsed_time": 4569, "timer_time": 4480, "position_lat": 32.75025587528944, "position_long": -117.13018745183945, "distance": 14.16679, "altitude": 0.11679999999999996, "speed": 8.686285714285715, "heart_rate": 150, "cadence": 81, "temperature": 15, "fractional_cadence": 0 }closes #29