From a5ad7fbb38fe17dc025e2d11f941334d29dc2b35 Mon Sep 17 00:00:00 2001 From: Andrew Garner Date: Mon, 30 Sep 2024 22:09:27 -0500 Subject: [PATCH] Ensure cf push of the example-service-instances-api app is checked This failed because the app manifest was hardcoded with GOVERSION=1.21 which was no longer supported by the cloudfoundry environment. Unfortunately the test proceeded anyway and failed later in a way that was harder to troubleshoot. Now the feature flags tests asserts that cf push actually succeeds - or at least cf push exits non-zero and flags a better error message up-front. --- system_tests/feature_flags/feature_flags_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system_tests/feature_flags/feature_flags_test.go b/system_tests/feature_flags/feature_flags_test.go index 511adece..05cf389b 100644 --- a/system_tests/feature_flags/feature_flags_test.go +++ b/system_tests/feature_flags/feature_flags_test.go @@ -81,13 +81,13 @@ var _ = Describe("FeatureFlags", func() { siAPIUsername := "siapi" siAPIPassword := "siapipass" - cf.Cf("push", + Expect(cf.Cf("push", "-p", os.Getenv("SI_API_PATH"), "-f", os.Getenv("SI_API_PATH")+"/manifest.yml", "--var", "app_name="+appName, "--var", "username="+siAPIUsername, "--var", "password="+siAPIPassword, - ) + )).To(gexec.Exit(0), `cf push example-service-instances-api app failed!`) brokerInfo = bosh.DeployBroker( "-feature-flag-"+uniqueID,