Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please explore a ComfyUI version of stablesr? Eager to use stablesr in ComfyUI! #54

Open
Jeff-goal opened this issue Oct 20, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@Jeff-goal
Copy link

Jeff-goal commented Oct 20, 2023

Eager to use stablesr in ComfyUI, which is the best upscale method for realphoto, especially for lowres or blurry pic.

@Jeff-goal Jeff-goal changed the title Could you please explore a ComfyUI version of stablesr? Eagle to use stablesr in ComfyUI! Could you please explore a ComfyUI version of stablesr? Eager to use stablesr in ComfyUI! Oct 20, 2023
@IceClear
Copy link
Collaborator

Hi. Thanks for your interest of our work! We are very busy recently. We may consider this later. Contributions are also really appreciated :)

@WSJUSA
Copy link

WSJUSA commented Nov 4, 2023

@IceClear hi Jianyi - did you see this I put together:
https://github.com/WSJUSA/Comfyui-StableSR

It has bugs because the way Comfy builds the Unet model is different (beyond my expertise). I received some suggested fixes in this thread: WSJUSA/Comfyui-StableSR#1 which I am going to apply and try out

Basically I have worked out how to access the objects needed to apply the unet highjack. Math and tensor details are well beyond my skill.

Hope this can accelerate a Comyui implementation

@IceClear IceClear added the enhancement New feature or request label Nov 4, 2023
@IceClear IceClear pinned this issue Nov 4, 2023
@IceClear
Copy link
Collaborator

IceClear commented Nov 4, 2023

@IceClear hi Jianyi - did you see this I put together: https://github.com/WSJUSA/Comfyui-StableSR

It has bugs because the way Comfy builds the Unet model is different (beyond my expertise). I received some suggested fixes in this thread: WSJUSA/Comfyui-StableSR#1 which I am going to apply and try out

Basically I have worked out how to access the objects needed to apply the unet highjack. Math and tensor details are well beyond my skill.

Hope this can accelerate a Comyui implementation

Thanks for your kind implementation :) I may go through it later when I have time. Thanks a lot. BTW, you may add me to the repo if you do not mind.

@alenknight
Copy link

came here to say this too. I absolutely love using this extension in Automatic1111 and often have to throw images into it instead of using comfyui workflows. sure wish I could have this in comfy

@IceClear
Copy link
Collaborator

IceClear commented Dec 3, 2023

came here to say this too. I absolutely love using this extension in Automatic1111 and often have to throw images into it instead of using comfyui workflows. sure wish I could have this in comfy

Thanks for your interest of StableSR :) May I know if this repo works well or problems still exist?

@WSJUSA
Copy link

WSJUSA commented Dec 3, 2023 via email

@EricRollei
Copy link

Just stopping by to say there's interest in a comfyUI implementation of stablesr

@CCpt5
Copy link

CCpt5 commented Feb 1, 2024

Just stopping by to say there's interest in a comfyUI implementation of stablesr

This newish fork works for ComfyUI: https://github.com/gameltb/comfyui-stablesr

Love StableSR - hope these developers keep working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants