Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let targets contain multiple filters #2

Open
2 of 3 tasks
pobiega opened this issue Apr 13, 2017 · 1 comment
Open
2 of 3 tasks

Let targets contain multiple filters #2

pobiega opened this issue Apr 13, 2017 · 1 comment
Assignees

Comments

@pobiega
Copy link
Owner

pobiega commented Apr 13, 2017

Targets should be able to have multiple filters and let the user specify if all or just one filter must match,

Suggested implementation:
Create a FilterGroup class that contains several Filters and a FilterStrategy. The group checks the internal filters when a match request is sent, respecting its associated strategy.

  • Create FilterGroup and all it's requirements
  • Modify UI to allow usage of new functionality (Add target window)
  • Refactor the Add target window to also work as a "edit target" window.
@pobiega pobiega self-assigned this Apr 13, 2017
@pobiega
Copy link
Owner Author

pobiega commented Apr 13, 2017

Edit functionality not yet added, but should be trivial with new filterSettingsDialog implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant