Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Hard-coded responses in shareInfoToResourceInfo #162

Open
michielbdejong opened this issue Nov 23, 2021 · 6 comments
Open

Hard-coded responses in shareInfoToResourceInfo #162

michielbdejong opened this issue Nov 23, 2021 · 6 comments
Assignees

Comments

@michielbdejong
Copy link
Member

We still have hard-coded responses from this function
In the case of addReceivedShare it's even a hard-coded JSON string

@ishifoev
Copy link

ishifoev commented Dec 1, 2021

I think we need 2 step work. The first one is that do we need an endpoint from Reva. We just mockup it and have hardcoded data, but we can't take it from the Reva side. But the second one does we need to save in an additional table this permission.

@ishifoev
Copy link

ishifoev commented Dec 1, 2021

On next cloud we have a permission like an integer. But from Reva side we need to save it like array of permissions

"permission_set" => [
				"add_grant" => false,
				"create_container" => false,
				"delete" => false,
				"get_path" => false,
				"get_quota" => false,
				"initiate_file_download" => false,
				"initiate_file_upload" => false,
];

@michielbdejong
Copy link
Member Author

@Triantafullenia-Doumani will look at this this afternoon from 13:00

@Triantafullenia-Doumani Triantafullenia-Doumani moved this from Issue In Progress to Todo in sciencemesh-nextcloud Dec 3, 2021
@michielbdejong
Copy link
Member Author

The values are these: https://github.com/pondersource/nc-sciencemesh/blob/099b11e/lib/Controller/RevaController.php#L251-L306
They should stay in the same response format, but come of the database

@michielbdejong
Copy link
Member Author

Maybe shareInfoToResourceInfo is sometimes used in the role of nextcloudShareObjectToRevaShareTable

@michielbdejong
Copy link
Member Author

Note: the 'permissions' column should be removed from the ScienceMeshShares table. Instead, we store them using getPermissionsCode

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

No branches or pull requests

3 participants