Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect: display=chip sizes #17288

Open
4 tasks
honboubao opened this issue Jan 3, 2025 · 0 comments · May be fixed by #17289
Open
4 tasks

MultiSelect: display=chip sizes #17288

honboubao opened this issue Jan 3, 2025 · 0 comments · May be fixed by #17289
Assignees
@cagataycivici @mertsincan
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
19.1.0

Comments

@honboubao
Copy link
Contributor

honboubao commented Jan 3, 2025 •
edited
Loading

Describe the bug

A MultiSelect with Chips in the size small or large increases its height when a value is selected, compared to when it's empty.

Pull Request Link

#17289

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/stackblitz-starters-3vqphm7e

Environment

Windows 10
Firefox 128.3.1esr

Angular version

19.0.5

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Add a MultiSelect with display="chip" and size="small" or size="large"
  2. Select a value
  3. Observe an increase in the components height

Expected behavior

MultiSelect should be displayed with a consistent height, irregartles of its selection state.
@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 3, 2025
honboubao pushed a commit to honboubao/primeng that referenced this issue Jan 3, 2025
fix: primefaces#17288 MultiSelect chip sizes
c44aede
@honboubao honboubao linked a pull request Jan 3, 2025 that will close this issue
Open
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 15, 2025
@mertsincan mertsincan moved this from Review to Theme in PrimeNG Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

@mertsincan mertsincan

Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Theme
Milestone
19.1.0
Development

Successfully merging a pull request may close this issue.

fix: #17288 MultiSelect chip sizes honboubao/primeng
3 participants
@cagataycivici @honboubao @mertsincan