Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Issues with River Story Scroll on mobile breakpoint #881

Open
joshvogel17 opened this issue Jan 7, 2025 · 2 comments
Open
Assignees
Labels
brand bug Something isn't working

Comments

@joshvogel17
Copy link

joshvogel17 commented Jan 7, 2025

Describe the bug

This was noticed in production with RiverStoryScroll disabled, but in a mobile view. There are two issues:

  1. RiverStoryScroll does not appear to disabled at the mobile breakpoint.
  2. River components are overlapping each other.

Here is a short video from production to illustrate.
https://github.com/user-attachments/assets/c79e4fd4-b9eb-473b-b898-2bc41e4aeb72

Reproduction steps

1. On branch of Dotcom add `RiverStoryScroll` around Rivers in `ui/packages/solutions/routes/Detail/Detail.tsx`
2. Start server with command `script/server`
3. Go to http://github.localhost/solutions/use-case/devops?_features=contentful_lp_solution_pages on desktop.
4. Scroll down page to River Components.
5. Notice that `RiverStoryScroll` is disabled.
6. Change to mobile view
7.  Scroll down page to River section
8. Notice `RiverStoryScroll` is enabled and the River Components are overlapping each other.

Expected behavior

If `RiverStoryScroll` is disabled, then the Rivers should not have the RiverStoryScroll behavior in mobile view. If it is enabled, `River` components should not stack on top of each other.

Screenshots

Browsers

Chrome, Firefox, Safari

OS

No response

@joshvogel17 joshvogel17 added the bug Something isn't working label Jan 7, 2025
@raytalks raytalks added the brand label Jan 8, 2025
@stamat
Copy link
Contributor

stamat commented Jan 8, 2025

Original Story Scroll removal PR here: https://github.com/github/github/pull/356869

@joshvogel17
Copy link
Author

Original Story Scroll removal PR here: github/github#356869

Sorry, I'll update my repro steps. It was decided to remove from production.

@rezrah rezrah self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

4 participants