-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trailing visuals to the text field #3237
base: main
Are you sure you want to change the base?
Add trailing visuals to the text field #3237
Conversation
🦋 Changeset detectedLatest commit: 472b01b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d650220
to
5396bf2
Compare
Hey @bsatarnejad, were you planning on implementing the other kinds of trailing visuals we talked about in #3218 (comment) ? |
Hi @camertron Yes of course. |
…ling visuals including icon, text, label and counter
Hi @camertron In the React implementation of this component, I noticed an issue: when there’s a long trailing text, it takes up all the available space, leaving no room for the input field itself. The solution I’ve implemented for a long trailing text is to handle it by truncating it with ellipsis. I’d love to hear your thoughts on this solution! |
Uh oh! @bsatarnejad, the image you shared is missing helpful alt text. Check #3237 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 😄
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
…en it is too long
What are you trying to accomplish?
Like leading visuals in a text-field, add trailing visuals to it. As explained here.
Screenshots
Closes #3218
Risk Assessment
What approach did you choose and why?
Like leading visuals in text field, we add a section for trailing visuals:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.