Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange rate UI should display fees as well #52

Open
armaniferrante opened this issue Jun 16, 2021 · 0 comments
Open

Exchange rate UI should display fees as well #52

armaniferrante opened this issue Jun 16, 2021 · 0 comments

Comments

@armaniferrante
Copy link
Contributor

armaniferrante commented Jun 16, 2021 •
edited
Loading

The exchange rate shown doesn't include taker fees (though the calculated toAmount, i.e. the token on the bottom of the swap form does). We should either add a note that shows the taker fee or embed it into the displayed exchange rate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@armaniferrante