Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OPAL Common to create URIs #15

Open
adibaba opened this issue Jul 8, 2020 · 1 comment
Open

Use OPAL Common to create URIs #15

adibaba opened this issue Jul 8, 2020 · 1 comment

Comments

@adibaba
Copy link
Member

adibaba commented Jul 8, 2020

Since November 2019, OPAL Common provides a URI rewriter:
https://github.com/projekt-opal/common/blob/master/src/main/java/org/dice_research/opal/common/utilities/UriRewriter.java
This has to be used to rewrite URIs.

The current implementation of the converter is here:
https://github.com/projekt-opal/converter/blob/f466e2b033bd7bbb8cfa9a34fd5f23eb189145a6/opal-confirm-conversion-service/src/main/java/org/diceresearch/opalconfirmconversionservice/utility/OpalConfirmer.java
in methond generateOpalConfirmedUrl(...)

Both methods create the same hashes, see:
https://github.com/projekt-opal/common/blob/master/src/test/java/org/dice_research/opal/common/UriRewriterDemoTest.java

@adibaba adibaba changed the title Use Commons to create URIs Use OPAL Common to create URIs Jul 8, 2020
@adibaba
Copy link
Member Author

adibaba commented Jul 8, 2020

Update: Regarding the use of the URI rewriter above, now Catfish can be used to rewrite the URIs of Datasets and Distributions. This should be the way to go. It can be enabled in Catfish configuration: cleaningConfig.setCatalogIdToReplaceUris(CatalogId);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant