Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add RELEASE.md for the release process #1690

Merged
merged 2 commits into from
Jan 21, 2025
Merged

docs: Add RELEASE.md for the release process #1690

merged 2 commits into from
Jan 21, 2025

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Nov 19, 2024

docs: update README for version compatibility

fixes #1681

Signed-off-by: Kemal Akkoyun [email protected]

docs: update README for version compatibility

Signed-off-by: Kemal Akkoyun <[email protected]>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just had some questions :)

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just clarify that we don't have a cadence before merging?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments (:

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@bwplotka
Copy link
Member

Kind reminder @kakkoyun , would be nice to have it!

@kakkoyun
Copy link
Member Author

Thanks for the reminder. I'll wrap this up

Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
Copy link
Member Author

@bwplotka Ready for another round of reviews.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bwplotka bwplotka merged commit 56a2431 into main Jan 21, 2025
10 checks passed
@bwplotka bwplotka deleted the fix_1681 branch January 21, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a RELEASE.md
3 participants