New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks pagination has the count inside the next button #4624

Closed

sandbergja opened this issue Dec 9, 2024 · 1 comment

Assignees

Labels

bug 🐛

Member

sandbergja commented Dec 9, 2024

Expected behavior

When I have 40 bookmarks and go to the second page of bookmarks, the next button text says "Next"

Actual behavior

The button says "Next -> 21 - 40 of 40"

the pagination at the top of the bookmarks page. The previous button just says Previous, but the Next button is greyed out and says Next arrow 21 - 40 of 40

Steps to replicate

In firefox:

Go to catalog.princeton.edu
Do a search
Bookmark all in the first page of search results
Go to the second page of search results
Bookmark all on the second page
Confirm that you have 40 bookmarks
Go to your bookmarks
Go to the second page
Look at the text of the Next button

Impact of this bug

Looks very odd

sandbergja added the bug 🐛 label

christinach self-assigned this

Member

christinach commented Jan 14, 2025

This doesn't seem to be an issue anymore:

christinach closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment