Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accountId missing from config schema #579

Closed
shaunco opened this issue Dec 7, 2023 · 2 comments · Fixed by #580
Closed

accountId missing from config schema #579

shaunco opened this issue Dec 7, 2023 · 2 comments · Fixed by #580
Assignees
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@shaunco
Copy link

shaunco commented Dec 7, 2023

What happened?

error: pulumi:providers:cloudflare resource 'default_5_16_0' has a problem: could not validate provider configuration: Invalid or unknown key. Check pulumi config get cloudflare:accountId.

Example

The README for this repo (and the docs on Pulumi) show that config can optionally contain cloudflare:accountId, which worked great in v4 and was accessible through cloudflare.config.accountId, but is gone in v5, as the schema no longer includes it:

https://github.com/pulumi/pulumi-cloudflare/blob/ac85abc72cec78313e6fb2f61559d9b53fbb3fe6/provider/cmd/pulumi-resource-cloudflare/schema.json#L54-L135

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@shaunco shaunco added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 7, 2023
@shaunco
Copy link
Author

shaunco commented Dec 7, 2023

Looks like it was deprecated a near the end of v4 and removed in v5, so I guess the README and docs just need updated to reflect that.

@iwahbe
Copy link
Member

iwahbe commented Dec 7, 2023

Hey @shaunco. Thanks for pointing this out!

@iwahbe iwahbe added area/docs Improvements or additions to documentation and removed needs-triage Needs attention from the triage team labels Dec 7, 2023
iwahbe added a commit that referenced this issue Dec 12, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants