Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contact resistance has no influence on impedance #416

Closed
noelhallemans opened this issue Jul 22, 2024 · 1 comment
Closed

[Bug]: Contact resistance has no influence on impedance #416

noelhallemans opened this issue Jul 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@noelhallemans
Copy link
Contributor

Python Version

3.12.4

Describe the bug

When evaluating the impedance, varying the parameter "Contact resistance [Ohm]" has no effect on the impedance while it should.

Steps to reproduce the behaviour

Run prediction = problem.evaluate(params) with params containing "Contact resistance [Ohm]".

Relevant log output

No response

@noelhallemans noelhallemans added the bug Something isn't working label Jul 22, 2024
@NicolaCourtier
Copy link
Member

In order to use the "Contact resistance [Ohm]" parameter in a PyBaMM model, you need to enable this option when creating the model, e.g. using:
model = pybop.lithium_ion.SPM(options={"contact resistance": "true"})
Then set the value of this parameter using:
parameter_set["Contact resistance [Ohm]"] = 0.02

@BradyPlanden let's add this to the example in #405.

@NicolaCourtier NicolaCourtier self-assigned this Aug 7, 2024
@NicolaCourtier NicolaCourtier moved this to Done in v24.9 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants