Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Flaky tests since map_iter #870

Closed
vmoens opened this issue Jul 10, 2024 · 0 comments · Fixed by #869
Closed

[BUG] Flaky tests since map_iter #870

vmoens opened this issue Jul 10, 2024 · 0 comments · Fixed by #869
Assignees
@vmoens
Labels
bug Something isn't working

Comments

@vmoens
Copy link
Contributor

vmoens commented Jul 10, 2024

The map_iter PR (#847) causes the CI to sporadically fail.
I think the failing tests are in TestMap but I'm not 100% sure.

Cause

I believe this is due to the fact that this PR solved an issue previously unknown: before #847, index_with_generator was ignored in map and hence the related test didn't do much.

Now this is fixed. Not sure why but it seems the test is now failing when we use this generator.

I tried various things to fix this in #869 without success

cc @kurtamohler if you want to help!
@vmoens vmoens added the bug Something isn't working label Jul 10, 2024
@vmoens vmoens self-assigned this Jul 10, 2024
@vmoens vmoens linked a pull request Jul 11, 2024 that will close this issue
[BugFix] Refactor map and map_iter #869
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmoens vmoens

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BugFix] Refactor map and map_iter pytorch/tensordict
1 participant
@vmoens