Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve voting "loophole" #315

Open
nyalldawson opened this issue Jan 1, 2025 · 1 comment
Open

Resolve voting "loophole" #315

nyalldawson opened this issue Jan 1, 2025 · 1 comment

Comments

@nyalldawson
Copy link
Contributor

There's a loophole/ambiguity in the current voting process:

  1. Developer A opens a QEP
  2. Developer B looks over, and approves in its original state
  3. Developer C triggers discussion, as a result the QEP text is amended

This leaves the original approval vote from developer B in an ambiguous state -- does there previous approval still apply even though the text has changed?

We could resolve this by:

  1. Requiring a discussion period prior to any votes being cast - eg two weeks for discussion before any votes are permitted.
  • We'd also then need a minimum timeout for voting to avoid two initial approval votes from instantly triggering acceptance without time for any negative votes to be cast. This could be handled by either:
    • allowing negative votes during the discussion period
    • requiring a minimum time for voting to be open (the downside of this is that it would further slow the whole QEP process)
  1. Invalidate votes already cast whenever changes are made to the text, and require those voters to recast their votes
  2. Something else??
@troopa81
Copy link

troopa81 commented Jan 2, 2025

how do we plan to vote exactly ? 👍 and 👎 on the PR, +1 and -1 in the comments, approve/need for modification in PR

Regarding the proposition being modified after an already casted vote, I would propose to just make a last call message to remind everyone that the proposition is going to be accepted (in a period to be defined) if nobody complains anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants