[App] Allow to use single quotes in file name with the --code command line option (Fix #60120)
#60121
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agiudiceandrea
added
Bug
2 tasks
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
agiudiceandrea
changed the title
--code command line option (Fix #60120)--code command line option (Fix #60120)
rouault
approved these changes
Jan 12, 2025
|
I think we should either use some proper escaping function in Qt, or write something to escape all non-printable characters too. Apparently on Linux, filenames can contain almost all non-printable characters, and they will also cause a problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properly escapes the single quotes in file name since it is wrapped in single quotes in the Python command run by QgsPythonRunner.
Fixes #60120.