Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic doc build failing #18

Closed
amilsted opened this issue Jun 20, 2024 · 6 comments
Closed

Automatic doc build failing #18

amilsted opened this issue Jun 20, 2024 · 6 comments

Comments

@amilsted
Copy link
Collaborator

Hi @david-pl, it looks like the build/deploy workflow is failing because of a matplotlib error at the moment. Have you seen this before?
@Krastanov
Copy link
Collaborator

suspicious that a breaking release of numpy was released last week (for the first time in a decade)

@david-pl
Copy link
Member

Hm odd, no haven't seen that before. Did anybody try building this locally?

@david-pl
Copy link
Member

Looks like the issue is actually a new matplotlib version and a call by PyPlot to an outdated API. The fix is already merged in PyPlot (JuliaPy/PyPlot.jl#583), but there's no patch release yet.

I "fixed" it for now in #19 by pinning matplotlib to 3.8. In the long term, we should probably change to a different plotting library for the examples, but for now it's fine I suppose.

@david-pl
Copy link
Member

FYI, the successful run in the PR already deployed the latest version of the docs. I'll leave the PR dangling for a few days and merge then if there are no comments.

@amilsted
Copy link
Collaborator Author

Looks good to me!

@amilsted
Copy link
Collaborator Author

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Krastanov @amilsted @david-pl