New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up the module_active? code #230

Open

qq99 opened this issue May 29, 2014 · 0 comments

Labels

bug

Owner

qq99 commented May 29, 2014

Right now it's a huge hack, want to slap my past self

This doesn't function properly:

echoplexus/src/client/modules/code/client.js.coffee

Lines 40 to 46 in 90878bf

    
           window.events.on "sectionActive:#{@module.section}", => 
        
             return if !@$el.is(":visible") 
        
             if !@editorsInitialized 
        
               @refreshIframe() 
        
               @initializeEditors() 
        
               @editorsInitialized = true

Go to /
Go to code
Go to channel /foo
Code panel isn't alive due to the above's deficiencies

Anything that fires / listens to that event there is terrible code!!! 💢

qq99 added the bug label

qq99 changed the title ~~Fix up the module active? code~~ Fix up the module_active? code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment