Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC - detect uses of @ConversationScoped and fail the build #45413

Open
manovotn opened this issue Jan 7, 2025 · 3 comments
Open

ArC - detect uses of @ConversationScoped and fail the build #45413

manovotn opened this issue Jan 7, 2025 · 3 comments
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request

Comments

@manovotn
Copy link
Contributor

manovotn commented Jan 7, 2025

ArC does not support @ConversationScoped but we could detect it and fail the build.
ATM we don't recognize this scope at all meaning some beans will instead end up with @Dependent scope - which is an error we could tell the user about.

To do this, we'll probably need to register conversation scope as a built-in scope and then change ContextNotActive exception to specifically mention this scope is not supported.

This issue is a follow-up to #45383

@manovotn manovotn added area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request labels Jan 7, 2025
Copy link

quarkus-bot bot commented Jan 7, 2025

/cc @Ladicek (arc), @mkouba (arc)

@Ladicek
Copy link
Contributor

Ladicek commented Jan 7, 2025

Alternatively, we could scan the bean archive index for the @ConversationScoped annotation and if present, fail the build. (That technically wouldn't even require making ArC know about @ConversationScoped, because other scopes are virtually always guaranteed to be used.)

@manovotn
Copy link
Contributor Author

manovotn commented Jan 7, 2025

Alternatively, we could scan the bean archive index for the @ConversationScoped annotation and if present, fail the build. (That technically wouldn't even require making ArC know about @ConversationScoped, because other scopes are virtually always guaranteed to be used.)

True, although that would prevent users from implementing their own custom conversation context.
I know it's super unlikely though ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants