Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3.2 hw] DAC8831IBD noise #931

Closed
MorganTL opened this issue Jul 22, 2024 · 7 comments
Closed

[v1.3.2 hw] DAC8831IBD noise #931

MorganTL opened this issue Jul 22, 2024 · 7 comments

Comments

@MorganTL
Copy link

Flashed ff2c2c1 on v1.3.2 hardware, both DAC8831IBD outputs are very noisy.

Test setup

With ADC input

  • Connect 1Vpp 10kHz sine wave to ADC and oscilloscope blue channel using T splitter
  • Connect DAC to oscilloscope yellow channel

noisy

Using signal_generator

  • set amplitude to 1, signal to Cosine, frequency to 1000, symmetry to 0.5, phase to 0.0 using usb serial
  • Connect DAC to oscilloscope yellow channel

noisy_sig_gen

Related issue

@jordens
Copy link
Member

jordens commented Jul 22, 2024

Certainly doesn't look like a DAC issue and potentially not even a software issue then. Could you please check the ADC data?

@jordens
Copy link
Member

jordens commented Jul 22, 2024

And show me platform service

@jordens
Copy link
Member

jordens commented Jul 22, 2024

And the manufacturer will aid you with hardware issues. Who is it?

@ryan-summers
Copy link
Member

The linked issue implies this was built by Creotech, and the further information indicates this is indeed a DAC issue, as replacement of the DAC8831 with the AD5542A was claimed to have resolved this issue.

It seems like there is a concern that SPI timing characteristics may not be being met with the new DAC, but I don't see a significant difference between the two while taking a cursory glance.

@jordens
Copy link
Member

jordens commented Jul 22, 2024

@ryan-summers I'd be more cautious about those conclusions. I don't see how the issue implies manufacturer. The fact that excluding the ADC also makes the issue go away points elsewhere. Please let @MorganTL respond to my requests.

@MorganTL
Copy link
Author

And the manufacturer will aid you with hardware issues. Who is it?

The card is a production sample from us (M-labs). And I am the electronics engineer who debugged the hardware issue. I raised an issue here because @gkasprow suggested it maybe an SPI issue.

Certainly doesn't look like a DAC issue and potentially not even a software issue then. Could you please check the ADC data?
And show me platform service

Unfortunately, we returned the production sample to our PCBA provider for rework.

@jordens
Copy link
Member

jordens commented Jul 23, 2024

Non-reproducible then. Feel free to reopen when you get it back, can reproduce it, and have the requested info.

@jordens jordens closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants