Deadlock while using SSL + Proxy

[JosephP91]

Hi all! I found a deadlock while looking at this thread dump. It seems to be related to SSL and proxy.

https://www.dropbox.com/s/4bpyevdcrbdgmya/thread-dump-clean.txt?dl=0

[chrjohn]

I know. I commented on your StackOverflow post. :)

[chrjohn]

Probably the best we can do is to open a MINA bug. But I saw there still is one related report open with them which sounds similar.

[JosephP91]

Yes, are you referring to this? https://issues.apache.org/jira/browse/DIRMINA-1119

[chrjohn]

Yes that is the one.

[JosephP91]

I openend a new one and attached the thread dump: https://issues.apache.org/jira/browse/DIRMINA-1144

I noticed that the deadlock does not occurr in the mina version 2.0.20, but I want to do more test just to be 100% sure.

[chrjohn]

Thank you.

[JosephP91]

I can confirm that the mina-core 2.0.20 version is working. So basically, if you exclude mina-core from quickfix dependency inside pom.xml file and include the 2.0.20 version, it should be fine. Since this is not a quickfix bug, I think I can close the issue. Feel free to reopen it for further problems.

[chrjohn]

Thanks for analysing this. It is good to know that 2.0.20 does not have this bug. Would be interesting to know why but I hope the MINA guys will come up with something.

[swapnilgupta10]

@JosephP91 i have similar issue which i downgraded to 2.0.23 but still figuring dead lock issue. Wondering what led us to 2.0.20 to make sure it's working.? Do we have any release not for this issue to occur after any specific version?

[chrjohn]

This hopefully should be fixed with MINA 2.2.x
See #635

[swapnilgupta10]

@chrjohn Thanks for quick update.
As per your above pull request, look like we need mina version upgrade along with few changes in quick fix api.
Do we have any ETA to new release version for above change? Will this required jdk higher version than 1.8 +?

[chrjohn]

No, we do not have an ETA currently, still working on the 3.0.0 release which will most likely still use JDK8.
However, maybe we could also do a 2.3.x release with this change but actually I'd like that someone tests if that problem is really fixed.

[swapnilgupta10]

That would be great if we can cut a release 2.3.x with mina 2.2.2. I could perform some sanity testing if that's possible. (Will be difficult to reproduce this issue on our lower environment). Let me know when if that's possible. Thanks

Also, as per https://issues.apache.org/jira/browse/DIRMINA-1132
Look like with 2.2.2, entire SSL implementation has been changed. Also environment section under above ticket relates > JDK 1.8

[chrjohn]

MINA 2.2.2 is still JDK8, otherwise #635 could not have been built.

[chrjohn]

I have merged the changes into https://github.com/quickfix-j/quickfixj/tree/QFJ_2_3_x
Are you able to build a release from there and test it?

[swapnilgupta10]

Sure, I'll give a try. You mean build a snapshot release on my local and test?

[chrjohn]

Yes, exactly.

[x-leviathan]

Hi @chrjohn
Does recent released version 2.3.2 fix this deadlock bug? I notice quickfixj 2.3.2 uses Mina 2.2.4

[chrjohn]

#774 (reply in thread)

[x-leviathan]

Got it. Thanks. I will try to perform integration testing locally to verify.