-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation error for Sample pid field when ICAT value is None #314
Labels
bug
Something isn't working
expands-search-api
Issues relating to the ExPaNDS Search API section of this repo
Comments
VKTB
added
bug
Something isn't working
expands-search-api
Issues relating to the ExPaNDS Search API section of this repo
labels
Feb 1, 2022
We will probably face the same issue highlighted in #308 if we are setting the |
3 tasks
VKTB
added a commit
that referenced
this issue
Feb 4, 2022
VKTB
added a commit
that referenced
this issue
Feb 4, 2022
VKTB
added a commit
that referenced
this issue
Feb 4, 2022
VKTB
added a commit
that referenced
this issue
Feb 4, 2022
VKTB
added a commit
that referenced
this issue
Feb 4, 2022
7 tasks
7 tasks
VKTB
added a commit
that referenced
this issue
Feb 8, 2022
Co-authored-by: Matthew Richards <[email protected]>
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
VKTB
added a commit
that referenced
this issue
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
expands-search-api
Issues relating to the ExPaNDS Search API section of this repo
Description:
Sending the following request:
http://{{datagateway-api}}/search-api/datasets?filter={"include": [{"relation": "samples"}]}
returns
500 INTERNAL SERVER ERROR
:For ISIS, the
Sample
pid
PaNOSC field maps to theSample
pid
field in ICAT, however thepid
values of some ICAT samples areNone
. These samples are the ones that are causingValidationError
because the Samplepid
PaNOSC field is defined as mandatory in theSample
pydantic
model which means that it does not accept aNone
value.Following a chat with @louise-davies, we decided that we should set the
pid
at the Search API level. For example, whenpid
of an ICAT sample isNone
, we should instead take itsid
and set the PaNOSCpid
to bepid:<id>
. The decision was made based on the suggestions in icatproject/icat.server#231Acceptance criteria:
The text was updated successfully, but these errors were encountered: