Fixup no-PSK network customisation. #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than always serialising the psk fields, conditionally serialise them if the length of the password field text is greater than 0. Fixes #977 in combination with users waiting for cloud-init to complete.
cillian64
approved these changes
Jan 8, 2025
|
Dropping this. I can't see that it's going to do anything useful for the cloud_init case - even if it's slightly clearer on intent. It may help the wpa_supplicant case, however, where key_mgmt=NONE appears to be required for an 'open' network - but we've had no bug in that area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always serialising the psk fields, conditionally serialise them if the length of the password field text is greater than 0.
Fixes #977 in combination with users waiting for cloud-init to complete.