Remove Jetifier #610
Draft
Remove Jetifier #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a draft because I haven't tested it thoroughly yet. |
|
Couldn't you put the JAR into |
Not without using |
|
That's weird, I can see no reference to a PDFium symbol in pdfium-navigator. |
|
It uses the symbols indirectly through AndroidPdfViewer APIs. |
|
That's what I thought. So I expect that compiling |
|
It doesn't compile, you can try it out. |
|
Okay! I didn't expect gradle to check dependencies of precompiled JAR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
android.enableJetifier=truefrom yourgradle.propertiesif you were using Readium as a local clone.I addressed this by taking the jetified artifacts in my Gradle cache (running
jetifier-standalonedirectly failed) and importing them directly in the project. A downside is that now we have all the native libraries as part of the repository, which adds ~40 MB.