Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD PromptSaver node adds an extra 12seconds to first run #101

Open
drmbt opened this issue Oct 25, 2024 · 1 comment
Open

SD PromptSaver node adds an extra 12seconds to first run #101

drmbt opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@drmbt
Copy link

drmbt commented Oct 25, 2024

Description

I'm seeing a 12 second run time that isn't there for other save nodes, and that is really hurting me when using comfy with an API. It seems like the SD PromptSaver node might actually be flushing the flux model and reloading it into memory; I'm guessing that if not using the SD ParameterGenerator, this is what you're doing to get model name, which seems really inneficient. if model name could just be a string that would be ideal, or really anything that wouldn't trigger a reload

Reproduction steps

run any basic workflow using the SD PromptSaver, take a look at the inference time reported for that node on the first run from a cold boot

Image file

first run:
image
second run:
image
first run with a dummy empty model nullModel.ckpt:
image

@drmbt drmbt added the bug Something isn't working label Oct 25, 2024
@drmbt
Copy link
Author

drmbt commented Oct 25, 2024

interestingly enough, if i convert model_name to an input and don't connect anything, this isn't a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant