Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSL verification persistent #13

Open
alexandrevicenzi opened this issue Mar 21, 2019 · 2 comments
Open

Make SSL verification persistent #13

alexandrevicenzi opened this issue Mar 21, 2019 · 2 comments

Comments

@alexandrevicenzi
Copy link
Contributor

According to this insecure connection can be set on Session rather than in every request.

IMHO is better to set only once since you cannot change while the process is running.

@rohanpm
Copy link
Member

rohanpm commented Mar 21, 2019

I notice if insecure is used right now, it currently gives lots and lots of warnings like:

/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
2019-03-21 17:27:22 +1000 [WARNING ] Input Debug repo does not exist
2019-03-21 17:27:22 +1000 [ERROR   ] Output Rpm repo does not exist
2019-03-21 17:27:22 +1000 [ERROR   ] Output Source repo does not exist
2019-03-21 17:27:22 +1000 [WARNING ] Output Debug repo does not exist
2019-03-21 17:27:22 +1000 [WARNING ] Skipping current content triplet, some repos are missing
2019-03-21 17:27:22 +1000 [INFO    ] Getting input repos for input content sets:
	rhel-8-for-s390x-baseos-rpms
	rhel-8-for-s390x-baseos-source-rpms
	rhel-8-for-s390x-baseos-debug-rpms
2019-03-21 17:27:22 +1000 [INFO    ] Getting output repos for output content sets:
	ubi-8-for-s390x-baseos-rpms
	ubi-8-for-s390x-baseos-source-rpms
	ubi-8-for-s390x-baseos-debug-rpms
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:847: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)

I'm wondering if this fix would also cut down on the number of warnings...

@alexandrevicenzi
Copy link
Contributor Author

@rohanpm I guess not, I opened #14 to propose a solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants