Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CN: Remove base type checks in check.ml #801

Open
dc-mak opened this issue Dec 29, 2024 · 2 comments
Open

CN: Remove base type checks in check.ml #801

dc-mak opened this issue Dec 29, 2024 · 2 comments
Assignees
Labels
cn technical debt Something for internal cleanup

Comments

@dc-mak
Copy link
Contributor

dc-mak commented Dec 29, 2024

I'm fairly sure they are all redundant/should be caught by wellTyped.ml. Should also remove ensure_base_type and ensure_bits from wellTyped_intf.ml too.

@dc-mak dc-mak added cn technical debt Something for internal cleanup labels Dec 29, 2024
@dc-mak dc-mak self-assigned this Dec 29, 2024
@dc-mak
Copy link
Contributor Author

dc-mak commented Dec 30, 2024

Ugh, depends on #272 which is almost definitely not handling the integer promotions correctly in the presence of bit vectors...

@cp526
Copy link
Collaborator

cp526 commented Dec 30, 2024

Let's wait with this one for now. (1) It's nice if check.ml is self-contained, in that it includes all the type checks necessary for soundness without depending on another module (of course it currently does depend on wellTyped having sufficiently type-annotated the Mucore code), but more importantly (2) I want to explore ownership types, and then resource checking and basetype checking would be more intertwined; removing basetype checks from check.ml would undo work that I'd have to then re-do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cn technical debt Something for internal cleanup
Projects
None yet
Development

No branches or pull requests

2 participants