Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow suffix on Ubuntu dated codename versions #30667

Open
HonkingGoose opened this issue Aug 8, 2024 · 5 comments · May be fixed by #33308
Open

Allow suffix on Ubuntu dated codename versions #30667

HonkingGoose opened this issue Aug 8, 2024 · 5 comments · May be fixed by #33308
Assignees
@dave-b-b
Labels
good first issue Suitable for new contributors help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) versioning:ubuntu Ubuntu versioning

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

Update this regex so it accepts suffixed codename versions for Ubuntu:

renovate/lib/modules/versioning/ubuntu/common.ts

Lines 3 to 5 in ce6bf18

function isDatedCodeName(input: string): boolean {
return regEx(/^(?<codename>\w+)-(?<date>\d{8})$/).test(input);
}

Background info

Renovate does not pick up the latest version of Jammy from Docker Hub. For example: ubuntu-jammy-20240627.1 on Docker Hub.

The current regex never matches on ubuntu-jammy-20240627.1, because of the suffixed .1 at the end.

@rarkins will accept a PR to fix this problem, so I'm creating this issue to track the work. 😉

Related discussion:
@HonkingGoose HonkingGoose added type:feature Feature (new functionality) help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others versioning:ubuntu Ubuntu versioning good first issue Suitable for new contributors labels Aug 8, 2024
@dave-b-b
Copy link

I can take this one, if no one has taken it.

@dave-b-b
Copy link

I'm setting up my environment to work on this ticket, but one of the tests is failing. Should I wait to start working on it?

Screenshot 2024-08-13 at 5 50 55 PM

@rarkins
Copy link
Collaborator

rarkins commented Aug 14, 2024

I wouldn't let that test failure prevent you working on the issue. Which OS are you using?

@dave-b-b
Copy link

I wouldn't let that test failure prevent you working on the issue. Which OS are you using?

macOS

@rarkins
Copy link
Collaborator

rarkins commented Aug 14, 2024

It's probably a platform/OS problem although we do test cross platform on CI so it's interesting that it affects you. I use Mac too and haven't seen it locally. Anyway, please continue!

@ivankatliarchuk ivankatliarchuk linked a pull request Dec 27, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dave-b-b dave-b-b

Labels
good first issue Suitable for new contributors help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) versioning:ubuntu Ubuntu versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(versioning/ubuntu): support suffixed codename versions ivankatliarchuk/renovate
3 participants
@rarkins @HonkingGoose @dave-b-b