Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array for positions? #86

Open
stp-ip opened this issue Mar 15, 2019 · 6 comments
Open

Use array for positions? #86

stp-ip opened this issue Mar 15, 2019 · 6 comments

Comments

@stp-ip
Copy link
Member

stp-ip commented Mar 15, 2019

Is this a BUG REPORT or FEATURE REQUEST?:
feature

Should we switch from a single position to an array of positions instead, where the default usage would be a single string within the array?
LinkedIn and Angellist both use multiple positions. Example: "Founder, CTO".

@jahzielv
Copy link
Contributor

This sounds like a good idea, especially for folks at smaller companies that might have more than one role. (PS: I'm new to this project but would love to help out in any way! I love writing docs, and am also open to learning Go and helping with implementation as well. I'm super excited about what this project could accomplish, since I've been looking for a good solution like this one for a long time. Are there any particular issues that would be a good place to start?)

@stp-ip
Copy link
Member Author

stp-ip commented Mar 31, 2019

Great for jumping in and giving another viewpoint. Currently most things are still code related, but if you want to jump in the source of truth for the schema is written as a Go struct, which is located here: https://github.com/resumic/schema/blob/master/schema/schema.

Within this file this issue should be able to be solved. Basically move the string to an array, which you should have a few examples within the file. That would also help you understand the code and the structure right away.

That would also make documentation tasks easier later on.
In terms of understanding go primitives this resource is great: https://gobyexample.com/

Thanks for the effort and looking forward to contributions.

Paging @ArmanMazdaee that might also be able to add good starter issues both code and documentation.
Another one might be #76

@stp-ip
Copy link
Member Author

stp-ip commented Mar 31, 2019

Additional note:
We are using our own tag syntax to define additional data to the structs.

@jahzielv
Copy link
Contributor

jahzielv commented Apr 1, 2019

Sounds great! I've forked and will start reading through the code base to get more familiar with it. I'll take a swing at the version issue (#76) once I'm a little more used to the language and the project's code!

@jahzielv
Copy link
Contributor

Hey @stp-ip! I'm sorry for dropping off the map so suddenly – school started back up and I got pretty busy with coursework. I have some free time this weekend though so I figured I'd come back and try to submit some PRs! I'll take a crack at this one, should be relatively straightforward.

@stp-ip
Copy link
Member Author

stp-ip commented Oct 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants