From 2d7a2e512f6585855af531dd8e751852f6111b9b Mon Sep 17 00:00:00 2001 From: Richard Huang Date: Fri, 28 Aug 2015 21:18:59 -0700 Subject: [PATCH] Bugfixes. - Support edge case where the node's parent is not immediate parentNode. - Add contributing section into readme file. - Adjust changelog file - Bump up version to 1.2.4 --- CHANGELOG.md | 5 +++++ README.md | 10 ++++++++++ package.json | 2 +- src/chrome/assets/js/generator.js | 2 +- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 81256da..59fbb8b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +### 1.2.4 (2015.08.28) + +* Bugfixes +* Update readme file + ### 1.2.3 (2015.08.25) * Bugfixes diff --git a/README.md b/README.md index d3f6255..4fd5d98 100644 --- a/README.md +++ b/README.md @@ -59,6 +59,16 @@ $ gulp The `/dist` folder will contain distribution ready packages. +Contributing +- +If you would like to contribute code to Selenium Page Object Generator project you can do so through GitHub by forking the repository and sending a pull request. + +When submitting code, please make every effort to follow existing conventions and style in order to keep the code as readable as possible. Please also include appropriate test cases. + +Before your code can be accepted into the project you must also sign the [Selenium Page Object Generator CLA](https://goo.gl/forms/Bax4dq33Q7) (Individual Contributor License Agreement). + +That's it! Thank you for your contribution! + License - Copyright (c) 2015 Richard Huang. diff --git a/package.json b/package.json index a076913..e54405a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "selenium-page-object-generator", - "version": "1.2.3", + "version": "1.2.4", "description": "A nimble and flexible Selenium Page Object Model generator to improve agile testing process velocity.", "dependencies": {}, "devDependencies": { diff --git a/src/chrome/assets/js/generator.js b/src/chrome/assets/js/generator.js index 187cbfb..a458690 100644 --- a/src/chrome/assets/js/generator.js +++ b/src/chrome/assets/js/generator.js @@ -361,7 +361,7 @@ window.POG=(function() { var clonedParentNode = parentNode.cloneNode(true); var clonedNode = clonedParentNode.querySelector( node.nodeName.toLowerCase()); - clonedParentNode.removeChild(clonedNode); + clonedNode.parentNode.removeChild(clonedNode); text = clonedParentNode.textContent || clonedParentNode.innerText || ''; text = text.trim();