Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ou_strategy noise missing dt? #194

Open
zacwellmer opened this issue Nov 7, 2017 · 3 comments
Open

ou_strategy noise missing dt? #194

zacwellmer opened this issue Nov 7, 2017 · 3 comments

Comments

@zacwellmer
Copy link

zacwellmer commented Nov 7, 2017

I could be wrong but it seems like we need to add a dt parameter to ou_strategy.py's evolve_state function?

as per the openai baseline noise

def evolve_state(self):
    x = self.state
    dx = self.theta * (self.mu - x) * self.dt + self.sigma * np.sqrt(self.dt) * np.random.normal(size=self.action_space)
    self.state = x + dx
    return self.state
@dementrock
Copy link
Member

Make sense. Would you like to submit a pull request?

@zacwellmer
Copy link
Author

#197 submitted

@schneimo
Copy link

schneimo commented Jun 21, 2019

Another question regarding to the OU noise process here:
In baselines the previous state is set to a zero-array, wherefore here in rllab the state is set to an array filled with ones!?
I think that the baselines noise is correct, because so the noise is centered around 0, or not?

Baselines:

def reset(self):
        self.x_prev = self.x0 if self.x0 is not None else np.zeros_like(self.mu)

rllab:

def reset(self):
        self.state = np.ones(self.action_space.flat_dim) * self.mu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants