Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slitherlink colors are challenging for my colorblindness #255

Open
glasser opened this issue Nov 11, 2021 · 6 comments · May be fixed by #280
Open

Slitherlink colors are challenging for my colorblindness #255

glasser opened this issue Nov 11, 2021 · 6 comments · May be fixed by #280

Comments

@glasser
Copy link
Contributor

glasser commented Nov 11, 2021

I am colorblind and find the yellow and green chosen for the slitherlink in/out colors to be challenging to distinguish. Would it be possible to change one of the colors to something more distinct (or provide a "randomize colors" button like exists for the lines, which is super helpful to me)?

(I like this page for finding distinct colors, specifically in 99% or 99.99% mode in "convenient" order choosing early ones: https://sashamaps.net/docs/resources/20-colors/)

@robx
Copy link
Owner

robx commented Nov 17, 2022

I'd be happy to tweak the colors a bit to something that works better for you, would you like to make a concrete suggestion? We could try that out and see if there are complaints the go beyond aesthetics.

If that doesn't work, another solution would be to make colors configurable. That feature existed in the past to some extent, but I'd rather aim to keep the number of configuration options low.

@glasser
Copy link
Contributor Author

glasser commented Nov 17, 2022

I had a chat about this last year on a Discord and I did get the impression that some people are really used to the current colors and wouldn't want it to change. (Specifically my workaround has been loading puzzlink puzzles into penpa, and I had proposed changing the secondary color there and there was reasonable pushback; however, penpa does let you configure the secondary color globally so that works.)

If you want to just change it for everyone, maybe keeping the same overall shades but making them more distinct would help. On the link above, I find "Yellow" and "Lime" very similar, but "Yellow" and "Green" are very distinct (due to darkness basically). That's ffe119 and 3cb44b. Or really, just changing qsubcolor1 to 3cb44b would be sufficient.

I'd be happy with configurability too but understand that more knobs means more complexity.

glasser added a commit to glasser/pzprjs that referenced this issue Nov 18, 2022
This makes the green color used for qsubcolor1 (eg, for slither) darker and thus more distinguishable from the yellow used for qsubcolor2 by people with some forms of colorblindness.

The particular color chosen is inspired by https://sashamaps.net/docs/resources/20-colors/ though I am not tweaking the other colors to come from here.

Fixes robx#255.
@glasser glasser linked a pull request Nov 18, 2022 that will close this issue
@glasser
Copy link
Contributor Author

glasser commented Nov 18, 2022

#280

@robx
Copy link
Owner

robx commented Nov 18, 2022

Or how about we set the colors via CSS, and provide an accessible alternative stylesheet (not sure how good browser support is in general for choosing alternate stylesheets, though). I don't think it's easy for users to provide their own styles these days, is it?

@glasser
Copy link
Contributor Author

glasser commented Nov 18, 2022

I hope whatever solution is chosen works on Android Chrome :)

@robx
Copy link
Owner

robx commented Nov 19, 2022

Another tool to look at for comparison is the player at kwontomloop.com. It does a number of things a bit differently (black for the loop, doesn't entirely fill the the grid cells), but could the shading colors used there work here? (I'm not suggesting necessarily using those precise colors, but they seem like a decent example of not-too-dark colors that are very distinct (to my eye) and that look quite nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants