-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web docs: use of link that ends with #something
should briefly highlight the function something
#7299
Comments
Doesn't this amount to adding a few lines to I'm asking because I'm surprised by the "intermediate issue" tag. Is there some trap in here?
Or do you mean to use the CSS transitions and want to animate the background change? I think a simple, instant change of background color would be sufficient. I think this is what the Rust docs do. |
In the rust docs there is a brief flash (you can see it on refresh), looks like it comes from here:
I think I was mostly leaving space for things are harder than they look from the outset :)
I think a brief background color flash is worth it, but we could do it in two PRs if you like. |
Ah, right, didn't notice it.
Ok. I'll give it a try if I find a moment. But I'm rather short on time, so if there is anyone interested in taking up the issue, then go ahead! |
Signed-off-by: Michał Kukieła <[email protected]>
Signed-off-by: Michał Kukieła <[email protected]>
Highlight current :target entry name (#7299)
Thanks for alerting me @lishaduck :) |
Usually this specific link scrolls to the function perfectly but you can't do this with the last functions, like with https://www.roc-lang.org/packages/basic-cli/0.17.0/Stdin#readToEnd
For that reason it would be good to highlight the function used in the link with something like a css background color transition, similar to this rust docs link: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.as_ptr
The text was updated successfully, but these errors were encountered: