Support accordion block, description block, teaser block. Make tooltip component customizable. #14
Conversation
…Make TooltipPopup customizable via component registry.
This reverts commit db84c5d.
ksuess
changed the title
There was a problem hiding this comment.
I finally made time to test this. Yes, this works. Thanks!
I made a few inline suggestions for the documentation.
Question: you are saying to register a new view for the description block. I am used to customising the existing view by putting it in customizations/components/manage/Blocks/Description/View.tsx. I tried it, and both work. I wonder if the documentation should show this second method instead. I don't really mind, and don't know which would be better.
I wonder if the same approach could work for the title block, and also the titles of accordions and teasers. But the client has not asked about this yet, and maybe it is better this way.
Thanks!
| ```js | ||
| import { TextWithGlossaryTooltips } from '@rohberg/volto-slate-glossary/utils'; | ||
|
|
||
| const DescriptionBlockView = ({ properties, metadata, id }) => { |
There was a problem hiding this comment.
In the configuration you set
config.blocks.blocksConfig.description.view = DescriptionBlockViewWithTooltips;
so the name here should be the same:
| const DescriptionBlockView = ({ properties, metadata, id }) => { | |
| const DescriptionBlockViewWithTooltips = ({ properties, metadata, id }) => { |
| ); | ||
| }; | ||
|
|
||
| export default withBlockExtensions(TeaserView); |
There was a problem hiding this comment.
In the blocks config you set teaser.view = TeaserViewWithTooltips, so that should be the item that is exported.
| export default withBlockExtensions(TeaserView); | |
| const TeaserViewWithTooltips = withBlockExtensions(TeaserView); | |
| export default TeaserViewWithTooltips; |
No description provided.