Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ROM v4 #17

Open
v-kolesnikov opened this issue Nov 3, 2017 · 0 comments
Open

Upgrade to ROM v4 #17

v-kolesnikov opened this issue Nov 3, 2017 · 0 comments

Comments

@v-kolesnikov
Copy link

v-kolesnikov commented Nov 3, 2017

Hi, folks!
I tried to update (#16) rom-csv to rom-core v4 and add some useful features as well.
For example - I added support for multi-file database as in rom-yaml - and it is working!
But there is one thing that bothers me - commands layer. I temporary disabled it because it was based on mutable datasets, that in itself bad.

And now I have some questions:

  • Need we to support commands layer in CSV adapter?
  • Is it OK to use mutations in datasets to support commands? (I think not)
  • Which another rom-adapter will be better to use as conceptual example for the implemetation of commands layer? I look to rom-yaml and rom-mongo as most recently updated adapters.

@solnic @flash-gordon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant