Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROOT doesn't compile with gcc-15 #17444

Open
2 of 3 tasks
hageboeck opened this issue Jan 17, 2025 · 2 comments
Open
2 of 3 tasks

ROOT doesn't compile with gcc-15 #17444

hageboeck opened this issue Jan 17, 2025 · 2 comments

Comments

@hageboeck
Copy link
Member

hageboeck commented Jan 17, 2025

Check duplicate issues.

  • Checked for duplicates

Description

Starting from gcc-15, <cstdint> needs to be included when fixed-size integer types are used.
See also:
https://bugs.gentoo.org/942438

In ROOT, there is currently four places that create problems:

What could be the solutions to make ROOT compile cleanly?

  1. Wait until the llvm upgrade?
  2. Patch llvm ourselves until the upgrade?
  3. Pull in already now the commits from llvm-main? (the latter doesn't apply, though)

@devajithvs @hahnjo @amadio

Reproducer

Compile ROOT with gcc-15

ROOT version

Master, but also 6.34, 6.32 as can be seen in the gentoo bug report

Installation method

Source

Operating system

Gentoo

Additional context

No response

@hahnjo
Copy link
Member

hahnjo commented Jan 17, 2025

LLVM fixed those here and as a side effect here. The former applies cleanly, but the latter doesn't.

The first one we can backport. For the second one, as the header llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.h uses the fixed-size integer types directly, it should include <cstdint> directly and not transitively via llvm/ADT/SmallVector.h. This should be fixed upstream (regardless of it being fixed as a side effect) and then we can backport that.

@hageboeck
Copy link
Member Author

hageboeck commented Jan 20, 2025

One more location found by mellert: #17455

@hageboeck hageboeck self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants