Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fa() should return a htmltools::tag() object #58

Open
cpsievert opened this issue May 11, 2021 · 2 comments · May be fixed by #59
Open

fa() should return a htmltools::tag() object #58

cpsievert opened this issue May 11, 2021 · 2 comments · May be fixed by #59
Assignees
@rich-iannone
Labels
Difficulty: ② Intermediate Effort: ② Medium Priority: ② Medium Type: ★ Enhancement
Milestone
v0.6.0

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented May 11, 2021 •
edited
Loading

Using tag() over HTML() is would make the return value more customizable and more consistent with the return value of fa_i()
cpsievert added a commit to cpsievert/fontawesome that referenced this issue May 11, 2021
@cpsievert
Close rstudio#58: have fa() return a htmltools::tag() object
1790590
@cpsievert cpsievert linked a pull request May 11, 2021 that will close this issue
Open
@rich-iannone rich-iannone self-assigned this Nov 8, 2021
@rich-iannone rich-iannone added this to the v0.3.0 milestone Nov 8, 2021
@rich-iannone rich-iannone modified the milestones: v0.3.0, v0.4.0 Jul 1, 2022
@rich-iannone rich-iannone modified the milestones: v0.4.0, v0.5.0 Oct 18, 2022
@sanjmeh
Copy link

sanjmeh commented Jan 10, 2023

Is this the reason the following code does not (still) work?

 menuItem(text = "Truck Monster",icon = fa(name = "truck-monster",height = "30px"))

@rich-iannone rich-iannone modified the milestones: v0.5.0, v0.6.0 Jan 25, 2023
@sanjmeh
Copy link

sanjmeh commented Jan 29, 2023

I keep getting the followng error unless I remove all icon = fa(..) from my menuItem(...) lines.

Warning: Error in tagAssert: Expected an object with class 'shiny.tag'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rich-iannone rich-iannone

Labels
Difficulty: ② Intermediate Effort: ② Medium Priority: ② Medium Type: ★ Enhancement
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Have fa() return a htmltools::tag() object cpsievert/fontawesome
3 participants
@cpsievert @sanjmeh @rich-iannone