-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture version tags as releases #5
Comments
The dashboard now fetches releases and tags. No releases falls back to tags. No tags falls back to default "none yet message" |
Nice work! I see c964705 looks like the relevant commit? One enhancement would be to compare the timestamps on the latest release and the latest tag and use the newer of the two. This is relevant for repositories like https://github.com/mirage/ocaml-ipaddr/releases. I can't recall what timestamp formats are in use so this may require adopting a dependency on a library if they aren't both RFC 3339 or whatever. Off the top of my head, I think RFC 3339 timestamps are comparable lexicographically. |
@dsheets yes, RFC3339 can be ordered lexicographically (see https://tools.ietf.org/html/rfc3339#section-5.1) (if same timezone is used etc.) |
I don't think we can ensure that Mirage projects always create GitHub releases but improvements like ocaml-opam/opam-publish#41 will help. I think if there is a more recent version-like tag than the most recent release, it is probably the most recent publication. Another option is to interface with |
my humble opinion is that dashboard needs some information from opam files anyways, and thus we should extract the version number also via opam ;) [other information such as tags/maybe changelog/maintainer/author/dependencies?] I'd think for now date comparison is fine, and once we've a better view what we want we can still switch over to opam information... |
A lot of projects don't use the GitHub Release API (it's just another step in the release process and hasn't been thoroughly automated yet) so it would be nice to grab tags that look like version numbers, too.
The text was updated successfully, but these errors were encountered: