From 7d9a4e4ca51070e5404fdb03bd0e88b6dc1480b4 Mon Sep 17 00:00:00 2001 From: Ruoming Pang Date: Sun, 8 Dec 2024 16:56:39 +0000 Subject: [PATCH] Adds a comment about the ordering of unscheduled jobs. --- axlearn/cloud/common/scheduler_test.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/axlearn/cloud/common/scheduler_test.py b/axlearn/cloud/common/scheduler_test.py index 9fa9eeb1..27fd91c0 100644 --- a/axlearn/cloud/common/scheduler_test.py +++ b/axlearn/cloud/common/scheduler_test.py @@ -435,6 +435,8 @@ def test_validate_tiers(self): resource_limits=[{"v4": 1}, {"v4": 1}, {"v4": 1}], expected_project_limits={"a": {"v4": 0, "v3": 0}, "b": {"v4": 3}}, expected_verdicts={"a1": False, "b1": True, "b2": False}, + # While both "a1" and "b2" are not scheduled, "b2" is ranked ahead of "a1" because + # its demand/limit ratio is lower (there's no v3 resource, so a1's ratio is infinite). expected_tiers={"b1": 2, "b2": None, "a1": None}, ), # Test that we can accumulate across tiers across resource types.