Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trait implementation of std::str::pattern::Pattern #1233

Open
BurntSushi opened this issue Oct 24, 2024 · 0 comments
Open

remove trait implementation of std::str::pattern::Pattern #1233

BurntSushi opened this issue Oct 24, 2024 · 0 comments

Comments

@BurntSushi
Copy link
Member

BurntSushi commented Oct 24, 2024

While the Pattern trait sat unchanged for years, it seems that recently, some breaking changes have been landing to it:

And truthfully, I don't like the idea of regex compilation depending on unstable features and thus being apt to break arbitrarily. In the most recent case, it seems like it just broke due to an API oversight. And since it's an unstable API, not a lot of attention is paid to quality control on these APIs.

My sense is that there are a number of folks using this trait implementation for one reason or another. In particular, when a breakage does occur, it seems to get reported very quickly. So I wanted to file this issue to hear from folks relying on this. Why are you using unstable APIs instead of just using a Regex directly?

robik75 added a commit to matter-labs/zksync-protocol that referenced this issue Oct 25, 2024
The `std::str::pattern::Pattern` trait implementation in the `regex`
crate recently broke compilation with the nightly rust toolchain.
The removal of the trait implementation and the corresponding `pattern`
feature is being
[planned](rust-lang/regex#1233).
This PR removes the reliance on this trait implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant