"error occurred: unknown target" when trying to add a new target

[0x0nyx98]

when forking the rust-lang/rust repo and attempting to add support for a new target triple, x will fail to recognise the new target when trying to build the cross compiling rustc

this happens when exactly following the directions laid out by "adding a new target" on the rustc dev guide, so either x has an issue with building the new rustc, or the documentation needs updating!

i've added the target triple to the supported targets macro, included it in the stage0 missing targets array, and (not entirely sure if this is necessary but still did it) supplied a json file with a rough specification of the target platform

the exact error given by x (presumably coming from the rustc used for building) is: error occurred: unknown target 'my-target-triple'

[0x0nyx98]

reproduced on nixos and debian by the way!

[jieyouxu]

Please include more specific repro steps. Best if you have some changes that we can checkout to try to repro locally or look at. The description as is is kinda vague ngl.

[0x0nyx98]

oh the repo im using is on my profile!
https://github.com/0x0nyx98/dostogo-rustc-target
it has a silly name i know >w<

i havent actually done any porting of the std/pal stuff yet because i am first trying to take care of this error
it really seems like it is on x's side , unless theres something missing from the docs ,,,, i dunno..

but the repro steps are really just following the docs on how to add a target -w- and setting up the usual information pertaining to one

[workingjubilee]

error occurred: unknown target `i686-unknown-msdos6`

the ` is not a ', unfortunately

[0x0nyx98]

oh , is that important , o////o sorry ,,,

[ChrisDenton]

Maybe this is related: https://github.com/rust-lang/cc-rs/blob/b886474a357ef5238848a42a1f9b2bccb6d45ee4/src/target.rs#L66-L73?

[jieyouxu]

AFAICT this is emitted from cc, you may need to temporarily fork cc to add your custom target, but this seems not ideal

[0x0nyx98]

oh !
thank you all for replying so fast i was not expecting this >w< , it is very much appreciated
i should probably mention just because it might be relevant , but , i am not making a target with intent to like , actually add it to rust! its just a hobby project that will stay on my little personal fork

i will look into forking cc! unless another solution pops up before i get to that
thank you :3

[workingjubilee]

oh , is that important , o////o sorry ,,,

not enormously, I was just noting for posterity's sake

seems rust-lang/cc-rs#1317

[jieyouxu]

Yeah, so:

• cc Discussion: Reconsider target parsing cc-rs#1317
• cc Repoint cc dep in bootstrap to its latest version. #134344 (that PR is blocked on not regressing cmake-rs / fixing cmake-rs)