Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Safe validation schema to allow null Safe version #568

Closed
hectorgomezv opened this issue Jul 17, 2023 · 2 comments
Closed

Change Safe validation schema to allow null Safe version #568

hectorgomezv opened this issue Jul 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@hectorgomezv
Copy link
Member

Problem
Some validation errors are being caused by Safes with a null version field.
Example here.
More context here.

Solution
Once the Safe{Core} team confirms this is a rare but expected case, make version field nullable in the Safe validation schema. Adjust OpenAPI schema and/or tests if necessary.

@hectorgomezv hectorgomezv added the bug Something isn't working label Jul 17, 2023
@fmrsabino
Copy link
Contributor

I don't think this is a bug. We can consider that these Safes are invalid also. One of the goals of the Safe Client Gateway is to provide to the UI clients a formatted response that we support. Right now we support safes that have a valid version.

@hectorgomezv
Copy link
Member Author

Closing the issue in favor of #569

@fmrsabino fmrsabino closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants